Piotr Denert

Results 26 comments of Piotr Denert

I've cleaned up packages which remain unchanged. I've removed limit from deprecated methods. I've updated iOS and Android implementations

> We could count how many they've selected and throw an exception, or discard extras if they've picked too many, but that's probably confusing, and can be implemented on the...

@vashworth thanks for the test examples. I've also added tests for variants where the limit is nil

@gmackall I've extracted getting final limit to `getLimitFromOptions` in `ImagePickerUtils` and suppressed the lint warning. I've also updated the native tests and added new ones for limit

> Quick review of the platform interface. I'll try to get a full review in asap for you. @tarrinneal hey, may you add your full review soon?

> > Quick review of the platform interface. I'll try to get a full review in asap for you. > > @tarrinneal hey, may you add your full review soon?...

PR with platform interface changes only is ready here: https://github.com/flutter/packages/pull/6434

@tarrinneal I have updated the PR to the published platform interface changes