PC

Results 10 comments of PC

> Closing, because documented alternative exist. There's a documented alternative for specifying compiler flags from within the sketch's directory? I apologize for necro-ing this thread, but if that's the case...

Just wanted to bump this PR as this would be an immensely useful addition. I see that the last mention of this was nearly 2 years ago. What more needs...

@h2zero Please let me know if there are any tests or other things I should try. I'm convinced this is just a mistake on my end, since it seems to...

Yes it is, but I just did a quick `cat * | grep min` and the same for `max` and I haven't redefined them, or even used them as a...

Oh boy, I think I've found it: https://arduinojson.org/v6/error/macro-min-passed-3-arguments-but-takes-just-2/ Looks like `Arduino.h` and `std::min` conflict. I'll see if I can fix this by changing the order of the `#includes`.

Reordering does partially fix things, but still produces compilation errors from `min` and `max` in `h2zero/hardware/arm-ble/0.1.1/cores/nRF5/Arduino.h`. Specifically the whole error is: ``` /home/pcook/.arduino15/packages/h2zero/tools/gcc-arm-none-eabi/9.3.1-1/arm-none-eabi/include/c++/9.3.1/bits/stl_bvector.h: In member function 'std::vector::size_type std::vector::_M_check_len(std::vector::size_type, const char*)...

I have confirmed that the issue is indeed in the `Arduino.h` definition of `min` and `max.` Commenting those lines out results in error-free compilation.

@h2zero It's unclear to me how exactly they fixed it in the samd core. Something to do with the underlying arduino-api. But here a permanent (albeit a bit sloppy) fix...

Can confirm this issue in native, LXC container, and docker installs. Seems the plugin is completely broken at the moment.

That makes perfect sense. Thanks for the quick reply!