Philipp Moritz

Results 85 comments of Philipp Moritz

I checked that wheels are only uploaded after the PR is merged -- let's try to merge it :)

After merging and the master build finished, the link is now indeed working 🎉

Very excited for this change, thank you so much for making it! This is code that is still around from a long time ago :)

There is a modin related test failure. Looks like we got lucky here and modin's dependency on run_functions_on_all_workers was removed here: https://github.com/modin-project/modin/pull/4603 so maybe bumping the modin version will fix...

Given this was a private API and has been deprecated for a while, I think it is fine to just remove it. But it is a good idea to mention...

Looks like one more lint is failing. I'll also try to get the remaining code owner approvals :)

There is another failure here: https://buildkite.com/ray-project/oss-ci-build-pr/builds/24959#01889a90-c54a-46c9-af89-0b62df111d16 :)

@jppgks Why can't you upgrade to 2.2? In general we don't backport features to old releases and encourage people to upgrade instead. If there is a blocker to upgrading, we...

Thanks a lot for doing this, this looks surprisingly simple -- do you forsee any trouble / problems with it going forward? What can go wrong here?