[Core] delete run_function_on_all_workers

[scv119]

Why are these changes needed?

This function is deprecated. Delete it to make our worker prestart change simpler. This PR depends on #31383

Related issue number

Checks

• [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• [ ] I've run scripts/format.sh to lint the changes in this PR.
• [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
• [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • [ ] Unit tests
  • [ ] Release tests
  • [ ] This PR is not tested :(

[pcmoritz]

Very excited for this change, thank you so much for making it! This is code that is still around from a long time ago :)

[scv119]

Will continue this after Ray 2.3.

[edoakes]

🤩

[scv119]

rebase

[scv119]

I feel like we need sth like a callback API that's called when the worker starts?

I thought that API called runtime env :)

[rkooo567]

Hmm I actually have 2 suggestions in this case?

https://docs.ray.io/en/master/ray-core/handling-dependencies.html -> I saw this doc, and it is not clear to me where to look in order to perform the same action. Can you link to the sub-category that has the exact API to replace this?

Instead of completely removing the function, why don't we keep the function but just raise an exception (for the backward compatibility)?

[stale[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

• If you'd like to keep this open, just leave any comment, and the stale label will be removed.

[rkooo567]

Unstale. We can replace this to https://docs.google.com/document/d/1ngiuAZAMnl9c4LozoTpWh37KPviDRIpmEjEI6BsNL7w/edit# by ray 2.5

[pcmoritz]

There is a modin related test failure.

Looks like we got lucky here and modin's dependency on run_functions_on_all_workers was removed here: https://github.com/modin-project/modin/pull/4603 so maybe bumping the modin version will fix this? I hope that's true, otherwise there will be pain.

[rkooo567]

cc @RehanSD for the awareness.

[rkooo567]

Also, I will make sure the replacement API will be available and documented by ray 2.6

[pcmoritz]

Given this was a private API and has been deprecated for a while, I think it is fine to just remove it. But it is a good idea to mention in the release notes the worker process init hook you are working on :)

[pcmoritz]

Looks like one more lint is failing. I'll also try to get the remaining code owner approvals :)

[pcmoritz]

There is another failure here: https://buildkite.com/ray-project/oss-ci-build-pr/builds/24959#01889a90-c54a-46c9-af89-0b62df111d16 :)

[scv119]

huh what a coincidence https://github.com/ray-project/ray/commit/369f68eade807133710648cb021903acdfe73f06#diff-41539696967c12463a48d082cec221167ea1b96ec702641db33479116c02297b

[pcmoritz]

Haha nice :)