Paul Chote

My other point still stands, so i'll repeat it: * The trait is called `GrantChargeDrainCondition` to match `GrantPrerequisiteChargeDrainPower`, but the configuration it exposes is completely different. This makes things unnecessarily...

I'm not asking for any functionality to be removed, just for it to be exposed in a consistent way to our existing traits. This trait isn't doing anything new, so...

Can you ~~reheat~~ rebase this with linguini?

FWIW, still changes requested on > I made a start on reviewing, but there is way too much here for me to properly evaluate in one go. Can we please...

Can all the confirmation dialog changes (and nothing else) go in a single PR?

Can you please reorder the commits so that the parsing logic commit is first? Trying to build and run on any but the last commit currently crashes on startup. Otherwise...

This is a big polish improvement, specially for nukes. Before: After: Some of the overlaps here might need a bit more tweaking?

The x11 freeze is caused by a deadlock in mesa's gallium driver. Set the environment variable to `GALLIUM_THREAD=0` to work around it. The current release ships quite an old version...

It doesn't feel right to have takeoff/landing sounds implemented directly via `Aircraft` but visuals having their own separate plumbing and trait. Can we please implement this directly?

If you insist, then please move the audio to the new trait here. Keeping distinct code paths for the same thing adds unnecessary technical debt and will require somebody else...