Philippe Canal

Results 332 comments of Philippe Canal

I am closing this PR. The resolution can be followed through the issue #12552. A new PR implementing the fine grained locking in `TClassTable` will be uploaded shortly.

The challenge here is that the code does silenty the 'wrong' thing. The compiler and the case where shadowing is disabled, correctly fail with a good error. While the current...

This fixes https://github.com/root-project/cling/issues/517

Humm ... I did not notice the PR was open against the intended repository. We need to have the PR done at https://github.com/root-project/root/pulls. I.e. you will need to reapply this...

It is okay-ish to have PR against this repo for user that work solely on Cling to provide feedback, however they indeed can not be merged and after verification against...

The patch applies cleanly, works and has been pushed to the v6-14-00-patches branch.

The following errors usually indicates uninitialised memory in the user data. ``` ==25280== Conditional jump or move depends on uninitialised value(s) ==25280== at 0x7D9DDCE: ZSTD_HcFindBestMatch_noDict_4 (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02819/slc7_amd64_gcc12/external/zstd/1.5.2-0530c990dd9ca27a8d966ab201ed2dfe/lib/libzstd.so.1.5.2) ==25280== by 0x7DBAE18:...

``` ==25280== Conditional jump or move depends on uninitialised value(s) ==25280== at 0x554C093: TFree::GetBestFree(TList*, int) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02819/slc7_amd64_gcc12/lcg/root/6.30.03-f674aef727eff41f98138d889e8a964c/lib/libRIO.so) ==25280== by 0x558B4E3: TKey::Create(int, TFile*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02819/slc7_amd64_gcc12/lcg/root/6.30.03-f674aef727eff41f98138d889e8a964c/lib/libRIO.so) ``` is a bit worrisome and...