cling
cling copied to clipboard
Fix diagnostic failure if an object return different types for begin() and end()
Fix compilation error when obj->begin()
and obj->end()
return different type.
This case is uncommon, but used sometimes. E.g, unbounded std::ranges::iota_view
This fixes https://github.com/root-project/cling/issues/517
@phsft-bot build
@pcanal Are the errors caused by the changes?
Humm ... I did not notice the PR was open against the intended repository.
We need to have the PR done at https://github.com/root-project/root/pulls. I.e. you will need to reapply this change to the Cling code within the ROOT repository.
Thanks.
Humm ... I did not notice the PR was open against the intended repository.
@pcanal is there a way to disable PRs on this repo? Or to have a phsft-bot 'warning' users that this is a mirror and that PR should be rather done to root ?
It is okay-ish to have PR against this repo for user that work solely on Cling to provide feedback, however they indeed can not be merged and after verification against the Cling-CI they should be migrated (by us or the user) to a ROOT PR.
Closing here as the user already moved the PR to ROOT: https://github.com/root-project/root/pull/14968