Peter Cai

Results 63 comments of Peter Cai

Thanks for your patience. Is this still relevant? I just tried your test case against main and it doesn't fail.

Thank you for the bisect but this doesn’t give me enough info to fix, and obviously I can’t just roll back that change since its a fix for https://github.com/savonrb/savon/issues/224 Can...

Thanks - it looks like `xmlns:awsse="http://xml.amadeus.com/2010/06/Session_v3"` appears twice in the envelope you provided for 2.15.1 - does deduplicating that fix your issue? or can you say more about which specific...

Thanks for your contribution. Wouldn’t this cause serialization to lose the attributes? That could be unexpected. It seems odd to support an interface with an intentionally lossy implementation. If you...

That might be a start, but I am guessing that would just introduce a problem on the worker side. A complete solution probably requires thinking about deserialization as well. After...

thank you for this - can you provide an example of what issue this solves? please rebase and re-integrate to deal with the merge conflicts

Thanks for the perfect repro. i ran this with `debug:true` on 2.14.0 and 2.15.1 and noticed this difference in the requests: savon 2.14.0 ``` ``` later versions: ``` ``` note...

mind checking if this fixes the issue? `gem "wasabi", github: "savonrb/wasabi", ref: "d4984c7a"`