Peter Cai

Results 63 comments of Peter Cai

Nevermind - you were the one who made the recent pr so that probably answers my question

Well, yes, that would be a clear win from a separation-of-concerns point of view.

Thanks for putting this together. planning to take a look at it all this weekend

Thanks again for this PR. Here's a quick plan: - get https://github.com/savonrb/wasabi/pull/116 merged in and cut a release of wasabi - rebase this branch and retest, get everything green and...

I'll need some time to delve into your cookie question, and may have some clarifying questions for you. I'm not familiar with this feature and don't work in savon day-to-day....

RE: your array cookie value question, I understand now: you allow a new magic key of literal "underscore" in the cookies hash. It allows passing an array of cookie flags...

thx @LukeIGS i will take a look today @eclectic-coding please make sure you force `rack < 3.1` - the recent release of rack, if bundled, forces an old and incompatible...

Unless I'm reading the logs wrong, its more than just an encoding difference - ruby-head returns the full namespace in addition to the method name ![image](https://github.com/savonrb/savon/assets/222655/697b2d49-4e3f-4b33-8e4f-c596acf54d29)

Please provide reproduction steps and expected vs actual output so we can try to help you. Also it would help to know which version combinations are working vs not working...

It might be, if you contribute it yourself. Or at the least it would be helpful if you opened a pr to add a failing test case for someone else