pcahyna
pcahyna
@antonvoznia is now producing examples of how will ShellCheck work in practice (by redoing old PRs with ShellCheck turned on). See selected examples in his reply. My plan is to...
> In general I am against muting what ShellCheck reports. Me too, and that's another good aspect of having differential checks: you can simply ignore the results if they are...
My plan for integrating this is as follows: @antonvoznia did some research on configuration adjustements needed. I will let him clean up and rebase his branch ( https://github.com/antonvoznia/rear/tree/differential-shellcheck ). Once...
Not completed - I plan to work on this as time permits, but I have more urgent issues now.
I believe #2903 addresses all the issues: > This fix alone is not enough because ReaR does not recognize the dependency between the PV and the /dev/sda disk and therefore...
hello @lachmanfrantisek, renaming `production_build` would certainly be nice, but I feel that it it is a mostly independent issue from this one. Even if you rename it, the issue that...
@TomasTomecek > Actually Packit performs the merge Ouch! So Packit builds and tests different code than the one in the pull request, because it includes unrelated changes from the target...
> Regarding this specific issue, I am slightly inclined for having a dedicated command for each job: > > * `/packit ` for basic retrigger > > * something like...
As an alternative, would it work to add a reaction ("I saw it") and then an error message as a reply to the comment explaining why the command is ignored?...
An error message would be more useful than not adding a reaction, which would be a bit less confusing, but still would not really help the user with debugging. The...