pcahyna

Results 326 comments of pcahyna

hello @lachmanfrantisek, renaming `production_build` would certainly be nice, but I feel that it it is a mostly independent issue from this one. Even if you rename it, the issue that...

@TomasTomecek > Actually Packit performs the merge Ouch! So Packit builds and tests different code than the one in the pull request, because it includes unrelated changes from the target...

> Regarding this specific issue, I am slightly inclined for having a dedicated command for each job: > > * `/packit ` for basic retrigger > > * something like...

+1 , I think this should be the default. I believe that changing source files (and the spec file is usually among source files) during build is an anti-pattern. If...

To be clear, I don't mean that not updating the spec should be the default, only that the updated spec file should go to a different place, leaving the original...

> 'network_iphost' is undefined\n Is this really an unrelated error message? I would rather say that it pinpoints exactly the problematic spot.

I suspect it is not supported, support for some ethtool options was added in #115, but WOL does not seem to be among them. Documentation for those that are supported...

@tyll more formally here: https://github.com/oasis-roles/meta_standards#ansible-best-practices

@codetronaut great! @thom311 @tyll could you please give advice? By the way, using the CheckPoint feature is already implemented in #119 , I believe.