Jason Crist

Results 126 comments of Jason Crist
trafficstars

I like the idea of being able to offer any of the fonts provided by Blockbase as font options by which to build derived themes. Leveraging the existing interface mechanisms...

> The benefit I see of putting it in a plugin is that it enables theme builders to create block themes easily before the tools are in Gutenberg Yea I...

I believe that handling fonts will ultimately need to be responsibility outside of the realm of this plugin. Other solutions (such as [this JetPack solution](https://github.com/Automattic/jetpack/pull/23045)) would work will with a...

This feels further and further from the realm of this plugin. There's too much complexity there and it will need to be handled well in some other area. I think...

> If Gutenberg is deactivated, the editor crashes when I click on the Create Block Theme panel, so perhaps a check should be added for whether to initialize this panel....

> Apparently they are also sorted different 😜 Ha. The values are exported alphabetically, which I think is usually the right thing. But that sure does make the sizes confusing!...

I tinkered with this concept a little bit today. It's not as straightforward as I was hoping. Within the site editor the markup of a pattern being used kind of...

I appears that due to [this recent Gutenberg](https://github.com/WordPress/gutenberg/pull/28514/files#diff-7bf60a59a90bcf0f53fa61af0e1717f2db7e31ff7bca1c0eb2e17389a351e1efL11) change that default Button Block styles now receive a black border by default (though, in the view only, not the editor... which...

There appear to be alignment discrepancies between the view and the editor. I don't believe this is due to this change as it's the view that appears to be incorrect....

The editor appears to have lost the padding in the Cover Block. Editor Before: ![image](https://user-images.githubusercontent.com/146530/108536204-28d53400-72aa-11eb-9676-87609c258fe2.png) Editor After: ![image](https://user-images.githubusercontent.com/146530/108536251-368ab980-72aa-11eb-90a7-ea207767f7c0.png) View: ![image](https://user-images.githubusercontent.com/146530/108536280-430f1200-72aa-11eb-8a6a-fa4faf2d73f9.png) Note that the cover block is pink in the view...