Pablo Bendersky
Pablo Bendersky
Just my 2 cents on a use case... I came across this issue, since I want to generate the docs on every commit and host them on GitLab Pages. The...
@Mogztter the problem is that when using Kroki, the image gets embedded externally (``) so I can't change any CSS style from the "caller" site.
@JanPawlov sorry! Just uploaded a fix. Would you mind trying it before we merge? You can change your `Gemfile` as: `gem "danger", :git => "https://github.com/pbendersky/danger.git", :branch => "issue-1106"`
They should be added to the regular comment, not the last inline comment. I do wonder if this is a product of your MR having the inline comments already present?...
Sounds ok to me then. On a new MR it should work properly. I don’t think it’s worth looking into the issue as it happened if you had previously run...
Hopefully! Thanks again for the feedback!
Are there any comments generated by danger in that MR? That code path should execute to edit the last comment. What does the API call for `https://git.domain.com/api/v4/projects/my_project/merge_requests/37/notes` return?
What about https://git.domain.com/api/v4/projects/my_project/merge_requests/37/discussions? Do you get results there? How many of those are generated by danger? Any of those not inlined? Thank you!
I'll check. Can you please tell me what comments did `danger` generate? Inline or not? From the error, I'd guess you had a non-inline comment and it failed when trying...
I think I'm having the same issue. I failed to pair, and now I get this log anytime I try to pair: ``` ip:192.168.1.47,mask:255.255.255.0,gw:192.168.1.1 >>> HomeKit: Got new client connection:...