Martín Fernández

Results 266 comments of Martín Fernández

> From a brief read of the code, as far as I can make out (I'm not technical), it seems that the device is not marked as having support for...

supporting zim files is easy using libzim but requires ICU, which is a big library to bundle. Also there's the limitation of 4GB files in fat32. Most zim archives with...

> Ideally, we would have ReaderLink:registerProtocolHandler(scheme, event) and your plugin would use self.ui.link:registerProtocolHandler("kolocalwiki://", "OpenLocalWikiPage"). (Which would make it standalone without the need to hack core - except by adding this...

Could you attach a picture? Hopefully it is an android 13 bug and it gets fixed automagically. It could be the case of a platform change affecting all targetSdk but...

> I wonder if [WindowInsetsCompat](https://developer.android.com/reference/androidx/core/view/WindowInsetsCompat#getDisplayCutout()) would work any better? It shouldn't. We're doing exactly the same in https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/MainActivity.kt#L173-L183 What `compat` methods provide is a way to do the call without...

@awbooze > Took a look at the verbose logs and found onAttachedToWindow() but no top x pixels not available Thanks for the feedback! That's the issue. Until now all android...

> I'm going to flash an A13 GSI image on my old tablet and see if I can reproduce the issue there. Nah. Google GSI doesn't even boot on my...

Thanks for the workaround, @emacsomancer. Here is a patch against luajit-launcher master, if somebody wants to try ```diff diff --git a/app/src/main/java/org/koreader/launcher/MainActivity.kt b/app/src/main/java/org/koreader/launcher/MainActivity.kt index d5b24bb..97b006b 100644 --- a/app/src/main/java/org/koreader/launcher/MainActivity.kt +++ b/app/src/main/java/org/koreader/launcher/MainActivity.kt @@...

> EDIT: apparently the patch only works when you install straight from github? Yes, the fdroid version doesn't allow changing the runtime behaviour of the app. > Anyway I guess...

A quick recap on this issue topic and potential workaround, as well as future fixes. 1. This ticket covers issues **with android 13** .Android 12 and before are not affected....