rust-payjoin
rust-payjoin copied to clipboard
payjoin
Payjoin Dev Kit scales Bitcoin, saves fees, and preserves privacy with one tiny library
The `process_res` methods across send and receive have a lot of shared code that can be extracted into reusable functions. `process_get_res` and `process_post_res` essentially do the same thing, and could...
We error out of we cannot predict the input weight of a p2wsh input [here](https://github.com/payjoin/rust-payjoin/blob/361c31e5627aec721eccf1e6e1042618adf94038/payjoin/src/psbt/mod.rs#L209). Wallets that spend non-key spend policies such as Liana cannot intergrate. I don't have a...
according to this comment 4 should be the max number of senders possible but the test does not fail when senders is set to 5. https://github.com/payjoin/rust-payjoin/blob/361c31e5627aec721eccf1e6e1042618adf94038/payjoin/tests/integration.rs#L747-L750
> Since this duplicates receiver::ImplementationError would be nice to de-duplicate in lib.rs or a core/error.rs module in a follow up. _Originally posted by @DanGould in https://github.com/payjoin/rust-payjoin/pull/552#discussion_r2020037908_
Somewhat related to #403 as it'll allow testing against specific error variants without string matching.
> I stared at this `&[2]` for a while wondering what it was. Makes me wonder if we ought to have a `Version` enum. _Originally posted by @DanGould in https://github.com/payjoin/rust-payjoin/pull/632#discussion_r2036428126_
The reliance on ohttp-relays can cause some distruption if they ever go offline but we did not have any examples of a fallback mechanism for choosing the relays at random...
@kumulynja mentioned to me that > [in] the last step of broadcasting the payjoin transaction I get the following error: > > BdkError.electrum(field0: Electrum server error: "sendrawtransaction RPC error -26:...
> This is working as expected but I do wonder if contexts here should be len == 1. Since both the hpke context and the proposal is the same it...
The reciever generates short ids as a unique identifier for each BIP-77 session. Its odd to me that [`id`](https://github.com/payjoin/rust-payjoin/blob/d674bd4fb8078e7259dd2441dddde02e73936475/payjoin/src/receive/v2/mod.rs#L588-L591) accepts a keypair only to use the public key. It should...