Results 41 comments of Paweł Miech

This is somewhat complicated because Scrapy uses Twisted Agents in downloader, and Twisted doesn't have socks client. There is only socks4 server. I did some research about this and there...

@whalebot-helmsman about fixing tests. Is it supposed to fix all possible tests failures? Because here in my PR I see some failures about mitmproxy installation and some about tox. https://github.com/scrapy/scrapy/issues/5166...

Great work finding this out @GeorgeA92. I found out this problematic line was added in this commit: 6fe82c621385cc194182fb525718195eafc4568e I'm not sure what were the reasons to add it. I created...

Encountered same thing now, and it seems this is more a documentation issue? If I understand it right, **you need to have other Spotify client open at the same time**?...

I would imagine this could work by just adding spider attribute `splash_enabled=True`. It attribute == True every request should have 'splash' meta key. Or we could even go without meta...

right @chekunkov if you only add `splash_enabled` argument we would also need `splash_options` (so two arguments needed) so maybe it would be easier to have `splash_options` and this will enable...

also question is: do we need 'meta' key for all splash requests? I think we don't need it if splash middleware is enabled in spider attribute.

hey @aleroot > is there anything built in handling an authorization mechanism ? no, nothing built in. You can do it in different ways. One way is to put scrapyrt...

To do this look up how max_requests are done now: https://github.com/scrapinghub/scrapyrt/blob/master/scrapyrt/core.py#L99 and add it in a similar way, need to count items collected somewhere here: https://github.com/scrapinghub/scrapyrt/blob/master/scrapyrt/core.py#L207 and close spider if...