pavel-bash

Results 14 comments of pavel-bash

Use CRON to set the schedule of queues export

@achulkov2 fixed most of your comments. I still need to fix the `queue_exporter_old`, but everything else you can give another look.

Use CRON to set the schedule of queues export

@ItIsApachee so, essentially, you want to remove the possibility to specify periods for the new implementation, and if they're anyway specified somehow, it will fallback to the old implementation?

Use CRON to set the schedule of queues export

@ItIsApachee @achulkov2 to summarize: the approach will be left as-is, in the form of functions over the `exportConfig` in `queue_exporter.cpp` file + I'll fix the comments from Andrei.

Use CRON to set the schedule of queues export

@achulkov2 @ItIsApachee I have addressed the PR comments, the only thing left is the test requested by Andrei, about which I'm not sure yet. Also, some of the older tests...

Use CRON to set the schedule of queues export

@Kontakter I have pushed a fix for the build, but I couldn't reproduce the failure locally, so I hope it'll work.

Use CRON to set the schedule of queues export

@achulkov2 fixed your last comments as well, also added the test.

Use CRON to set the schedule of queues export

@Kontakter changed it to `std::abs` as it suggests, hopefully it'll work...

Use CRON to set the schedule of queues export

@achulkov2 fixed.

Use CRON to set the schedule of queues export

> @pavel-bash let's add a test with some weird cron expression like `0 0 0 1 1 * 2026`. It's best we check that these kind of expressions don't break...

Store a user ID alongside the Cypress token instead of a username

@dim-an fixed most of the comments. Some remarks: > why not THROW_ERROR_EXCEPTION ? Most of the exceptions in that file are thrown with `THROW_ERROR`, so I've done the same for...