Paval Shlyk

Results 12 comments of Paval Shlyk

You can always test it by yourself)

Forgot to mention that CAN implementation primary was taken from this repo: https://github.com/marti157/ch32-can-rs

I'm testing CAN on 203g6u6 and I found that the filter don't work. Let's say I have: ```Rust let filter = CanFilter { bank: 0, mode: CanFilterMode::IdMask, id_value: (0x580 |...

I have introduced a new api for filters' configuration (with a bit `unsafe` code). But I still can't set up the filter correctly (it's probably a hardware bug, but even...

@andelf Using the feature flag is, of course, a matter of taste...) I prefer to give the user the ability to customize the library's functionality (as a way to speed...

@jalr Thanks for reporting an issue! Your code seems to be correct. I encountered a similar issue on my board. As far as I remember, it was a hardware misconfiguration....

@jalr Sorry for the too long answer. I had the same problem. For me, it was solved by setting a flag that the data has been read: ```Rust can.rfifo(fifo).write(|w| {...

@jalr I checked your code. There is not `receive` method for can (I have renamed it to `try_recv` in latest commit as more clarifying; `recv` method, by analogy with channels,...

@mickeprag That's great that you've found something not implemented. I see nothing in your code can break existing functionality. Therefore I'd recommend participating in this PR

@andelf What should we do move this PR?)