Pavel Smirnov comments

Results 6 comments of


                                            Pavel Smirnov

Minor version 3.4.0 introduces breaking changes

I think you should deprecate version 3.4.0 and release the same functionality as new major version 4.0.0 to help your dependents.

_get_sidecar_url should probably use django.templatetags.static.static instead of STATIC_URL

Hmm... For me this PR actually breaks the correct behavior 😀 The code now references a subdirectory, but directories are missing in `django.contrib.staticfiles.storage.ManifestStaticFilesStorage`. A directory is not a file, so...

_get_sidecar_url should probably use django.templatetags.static.static instead of STATIC_URL

@tfranzel for my project I will try to create a (temporary?) workaround. I planned to inherit from ManifestStaticFilesStorage and add directories to the manifest (if it is possible) or/and add...

_get_sidecar_url should probably use django.templatetags.static.static instead of STATIC_URL

I hope I'll have more info when I finish my workaround.

_get_sidecar_url should probably use django.templatetags.static.static instead of STATIC_URL

I went with a workaround for now. Just in case anybody stumbles upon this discussion, here is the code: ```python from django.contrib.staticfiles.storage import ManifestFilesMixin, StaticFilesStorage class MyFilesMixin(ManifestFilesMixin): passthrough_names = [...

"Export default class" doesn't work as expected

I've found [`jsdoc-export-default-interop`](https://www.npmjs.com/package/jsdoc-export-default-interop) plugin on npm that fixes the bug. Still, I hope it'll be fixed in the jsdoc3 without any side plugins.