Paul King

Results 55 comments of Paul King

I brought across the minor refactoring changes compatible with the existing gradle version

@eric-milles When the codenarcMain task is run, there are stack traces like below: ``` Error from [org.codenarc.rule.naming.ClassNameRule] processing source file [D:/projects/groovyCopy/subprojects/groovy-ant/src/main/groovy/groovy/ant/FileNameFinder.groovy] groovy.lang.MissingMethodException: No signature of method: org.codenarc.rule.naming.AbstractTypeNameAstVisitor.visitClassEx() is applicable for...

Yes, for our use of CodeNarc, the following changes are required: https://github.com/CodeNarc/CodeNarc/pull/707 There might be more rules we don't use that also need a change.

This needs a bit more work before we commit. Firstly, a minor thing, but we prefer the explicit imports over the * variant in nearly all cases for resilience against...

But you'd also need to check the hundreds of libraries/frameworks which use Groovy's api classes not just our usage.

This change might be okay but possibly not needed. This currently works: ``` def cli = new CliBuilder() cli.a(args: 1, longOpt: 'abc', type: double, 'abc') def options = cli.parse(['--abc', '0.0'])...

Do you have an example of where you'd use the type? In general, having code which relies on underlying implementation details is always harder to port compared to code which...

From that snippet, you are perhaps doing work you don't need to as most types are already handled. But if you really do need it, I would suggest using `getSavedTypeOptions()`...