Paulius Valiūnas

Results 72 comments of Paulius Valiūnas

Also, the documentation says: > Only attribute names from `metadata` should be used for pod_association's `resource_attribute`, because empty or non-existing values will be ignored. That's why I added the "already...

> We should add to the README that container fields can't be used for association. In that case, you should remove this section too: > 2. If the k8s.container.name resource...

Yes, the documentation needs to be a lot clearer. What exactly does "resource attributes are provided" mean? Do they have to be in the resource but _not_ referenced by `pod_association`?...

> it's `Fastify()` not `fastify()` If you import it as `import * as Fastify from "fastify"` or `import Fastify from "fastify"`, you're right. If you import it as `import *...

> Follow the instructions here: [fastify.dev/docs/latest/Reference/Type-Providers#type-definition-of-fastifyinstance--typeprovider](https://fastify.dev/docs/latest/Reference/Type-Providers/#type-definition-of-fastifyinstance--typeprovider), you need to add `TypeBoxTypeProvider` to `FastifyInstance` and use that instead. In my example, the type of `server` seems to be inferred correctly, and...

The problem is you can't use 8.0.0 with Typescript yet, because the `@types/chai-as-promised` package hasn't been updated yet. I'm using this workaround for now: ```ts import * as chaiAsPromised from...

are you still planning to merge this eventually?

this wasn't automatically closed by the PR, I guess it should be closed?

I think it makes sense from Typescript side. If there's no default generic argument, it will try to infer the type from surrounding code and throw if it fails. The...

So, to summarize the discussion: - `` does not solve the problem because it still allows assigning to a type with extra properties - Removing the generic altogether and returning...