chrome-har icon indicating copy to clipboard operation
chrome-har copied to clipboard
verified publisher icon sitespeedio

Add asyncIterator

Open Modeeeeeee opened this issue 1 year ago • 5 comments

Added support for asyncIterator. Per docs (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for-await...of) it supports both sync and async iterators so this PR includes

  • for await addition (harFromMessages is now async)
  • added a function processMessage
  • added a dummy test which has an asyncIterator

Modeeeeeee avatar Nov 13 '24 12:11 Modeeeeeee

Looks ok, so I'm thinking maybe having two different functions, but I can fix that. I'm doing a big refactoring that I want to happen first, but I can cherry pick your change if it's ok for you. Probably can merge/release Sunday.

soulgalore avatar Jan 18 '25 19:01 soulgalore

@soulgalore Sounds great !

Modeeeeeee avatar Jan 18 '25 19:01 Modeeeeeee

@soulgalore How is the release going ?

Modeeeeeee avatar Feb 10 '25 16:02 Modeeeeeee

are you still planning to merge this eventually?

paulius-valiunas avatar Mar 06 '25 14:03 paulius-valiunas

Yes, let me try to fix the async iterator, haven't had any focus on it yet.

soulgalore avatar Mar 06 '25 18:03 soulgalore