Paweł Krupa

Since k8s 1.19+ enables by default `EndpointSliceMirroring Controller` which should mirror custom Endpoints to EndpointSlice, maybe it makes sense to investigate if we can switch completely?

@efasel @AntonSmolkov would you like to work on this?

@mikechengwei any progress on this?

Fixed with #201

> Hm, I honestly don't know why the Ubuntu-Pipeline exited with 1 You need to run `make generate` and commit generated code changes too. --- The initial purpose of the...

`/prometheus` is managed by the operator. The expectation is to use `.spec.storage` field from PrometheusSpec to specify storage parameters. Note: this is a wrapper on volumeClaimTemplate and requires some sort...

We cannot directly use that guideline, unless we will refactor some part of codebase to use [runutil](https://pkg.go.dev/github.com/thanos-io/[email protected]/pkg/runutil?tab=doc)

> what would speak against refactoring Nothing, apart from time :)

Overall we tend to prefer Kubernetes native types over custom ones. In this particular case using label selectors is easier to manage as it does not require changing Prometheus object...

`NamespaceDefaultLabelName` is a fairly fresh addition to kubernetes (GA in 1.22) and it cannot be used by everyone. Since we want to support as many k8s versions as possible, we...