Paul E. Jones

It appears that some of the srtp_*() functions assume that parameters will present the SSRC in host order and some assume the SSRC will be in network byte order. I'd...

You want libsrtp to allocate memory and copy the packet data? That strikes me as less desirable than doing that in your code since you could, at the very least,...

OK. Then how is that different from: ```c memcpy(srtp_buffer, input_buffer, sizeof(input_buffer)); srtp_protect(srtp_buffer); ``` Just the desire of libsrtp to do the memcpy?

Yeah, SRTP's AES implementation will use the plaintext input as the state table array and operate on it in-place. So, I guess that's the issue here? It would be trivial...

Yeah, something like that'll work. I had my head one-level down further in the AES code itself. That doesn't matter: this code matters.

Fully agree. The SSRC lookup can be painfully slow if there are lot of them. Since these are (in theory) supposed to be random values, a tree might prove to...

Related to this: https://github.com/openssl/openssl/blob/master/doc/man7/migration_guide.pod#deprecated-low-level-mac-functions

srtp_hdr_t is a structure that represents an RTP header. It's not specific to SRTP, really. Why not just reproduce that if it's for testing purposes only? There is no risk...

I wonder how much faster your code can be using intrinsics functions?

I discovered the same behavior with C and C++ code. It does not seem possible to style a comment line that uses `/* */` style comments on a single line....