Paul Davis comments

Results 54 comments of


                                            Paul Davis

Remove unused includes to speed up build time

I cherry-picked the unused includes commit into ardour/master.

Random minor changes

all commits manually cherry-picked into master. thanks!

Add option to set note range in MIDI editor to one note.

I like the general idea quite a lot, but haven't had a chance to test it out yet. the newbbgui branch is the one most related to what x42 mentioned...

bounced region name issue

This commit will break for multichannel tracks, because you've removed the channel number from the name. I like the general idea. Care to fix that particular problem?

Update dark-ardour.colors - outline of selected midi notes

We could bring the fill feature back. It left in part because we added the velocity display bar, but I agree that the selected-note status is not sufficiently obvious at...

Update dark-ardour.colors - outline of selected midi notes

not sure what do about this. the goal is excellent, the result is good, but conflicts with the common selection color everywhere else. The problem is that when we have...

Update dark-ardour.colors - outline of selected midi notes

now implemented in git master branch (outline color used for velocity bar). Looks good!

Fixed overflow in std::numeric_limits<Temporal::Beats>::max()

This is a fix for a real problem, but it's not a correct fix. Any value should be acceptable as either ticks or beats, and ::normalize() should handle it.

Fixed overflow in std::numeric_limits<Temporal::Beats>::max()

It's not acceptable to expand either field to 64 bits. The entire value needs to fit within 64 bits. On Tue, Oct 17, 2017 at 3:25 PM, allen-marshall wrote: >...

Fixed overflow in std::numeric_limits<Temporal::Beats>::max()

Apologies for leaving this hanging around for so many years. In the end, I changed Beats to use a single 64 bit tick counter, and thus addressed this issue in...