Patrick Lee

Results 26 comments of Patrick Lee

i haven't looked into the details, but my guess is we don't need to materialize strings except for identifiers (and maybe a few other specialized tokens). If you want to...

`BeginNestedTransaction(WithReadRestriction(address))` I'm anti optional arguments in general. It's easy to accidentally misconfigure the call. I prefer something more explicit. I'm also anti-abbreviation in method names (and to a lesser degree,...

i've added some comments for clarification, and combined CommitToParent & CommitToMain into Commit

I'm not familiar with this part of the code base. I have a few ignorant questions: 1. why do you need to implement the queue using herocache? Implementing a queue...

IC. Queue implies the same number of items entering/leaving the collection, hence I assumed the items are unique. Perhaps a different name is more appropriate. This code doesn't seem to...