pattisahusiwa

Results 11 comments of pattisahusiwa

Unit test failed when adding `$verbosity` to Command class

These errors are reported by phpstan with error level 3. You can check the changes in my fork. ```txt ------ ----------------------------------------------------------------------------------------------------------- Line src/Application.php ------ ----------------------------------------------------------------------------------------------------------- 260 Method Ahc\Cli\Application::parse() should return...

When adding `$verbosity` property to `Command` or `Parser` class, this test fails because `$p->verbosity = 0`. To continue working on `phpstan`, this issue needs to be addressed. https://github.com/adhocore/php-cli/blob/c17fdec05954b3bd2df49adff56284a511dd1083/tests/Input/DefaultOptionTest.php#L53-L58

Unit tests failed after adding `declare(strict_types=1)` to all PHP files. Can you add the directive and fix the code? Also please check this issue https://github.com/phpstan/phpstan/issues/3916#issue-714277268

It's ok, we can ignore the error. I'll working on phpstan integration, but we need to collaborate on the PR. What do you think?

Yes. I don't use psalm. This pseudotype is introduced by [PHPStan 0.12](https://phpstan.org/blog/phpstan-0-12-released)

I never encountered this problem. ![phive](https://user-images.githubusercontent.com/11484016/96511215-bae81400-1299-11eb-99c9-f241837b16ca.png)

@ktrzos, you can use ``` $ deptrac --report-uncovered ``` to see the uncovered dependencies.

+1 for Maintainability Index Without comment. It would be nice if we can add the option in console argument (configuration) instead of this > An idea can be to add...