stonefish icon indicating copy to clipboard operation
stonefish copied to clipboard

`SimpleThruster` does not set thrust if there are no thrust limits set (the default)

Open jrtcppv opened this issue 5 months ago • 0 comments

Describe the bug Setting the setpoint (thrust and torque) on SimpleThruster ignores the thrust if it does not pass the check for upper limit > lower limit. By default the limits are (1, -1), so by default setSetpoint ignores input thrust.

To Reproduce Steps to reproduce the behavior: Set the setpoint on a SimpleThruster without setting the limits first, the call getThrust() and the thrust will have not changed.

Expected behavior Setting the thrust setpoint should work when limits are not set.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context You can see this via code inspection here: https://github.com/patrykcieslak/stonefish/blob/ec1ee1f3cf4a481e144040b66664ee49317bbdd9/Library/src/actuators/SimpleThruster.cpp#L61-L75

jrtcppv avatar Sep 19 '24 01:09 jrtcppv