Patrick Pircher

Results 136 comments of Patrick Pircher

> Is there a way to make it faster? Maybe, nodejs creates a new hidden class whenever a new property is added to an object... Lets see if thats the...

@chancancode i tried to improve the performance by checking with a `Set`. It actually only creates the html element if there are modifiers. I also wanted components that are under...

@chancancode i update the PR. by the way, inspector does not serialize+send **_every_** time something changes. I did improve the inspector long time ago to limit the calls to debug...

I found that in-element needed to add a destructor to release it in the debug render tree. Does this also need something similar?

I think i move everything to https://github.com/glimmerjs/glimmer-vm/blob/17ca94fdd58c5730c5f8b6f523e348ec03873f69/packages/%40glimmer/manager/lib/public/modifier.ts#L68

glimmer vm is also probably passing it as the only template information. captureRenderTree items has a property ``template` which is the same as moduleName

I think now this should be resolved in vitejs to also bind the functions just like rollup.

I also opened a PR on vitejs. But according to this comment https://github.com/vitejs/vite/pull/14569#pullrequestreview-1670210988 the functions are not bound in rollup. I also did a code search and could not find...

By the way, addWatchFile is not bound and access `this`. https://github.com/rollup/rollup/blob/fac5f1c1c12dc0409ff090664e305586747dc2f7/src/utils/PluginContext.ts#L61

it should be ready. I also making a PR to vite as well