glimmer-vm icon indicating copy to clipboard operation
glimmer-vm copied to clipboard

add tracked utilities for ember-inspector

Open patricklx opened this issue 2 years ago • 8 comments

so we do not need to do this hack: https://github.com/emberjs/ember-inspector/blob/8c4cd42a50b614981f8b863dfe07e116ced04953/ember_debug/object-inspector.js#L41

patricklx avatar Nov 03 '23 10:11 patricklx

@NullVoxPopuli can we have this?

patricklx avatar Nov 07 '23 10:11 patricklx

Maybe, i'm behind an getting the VM integrated in to ember, so that's blocking me actually reviewing all these prs.

At first glance though, does this need to be in production? Can we instead wrap all the behavior in meta.env?

NullVoxPopuli avatar Nov 07 '23 12:11 NullVoxPopuli

i think it would be nice to have it in prod as well. or when window.EmberENV = { _DEBUG_RENDER_TREE: true }; is set? or some other key? https://github.com/emberjs/ember-inspector/blob/main/skeletons/web-extension/scripts/boot.js#L1C21-L1C39

patricklx avatar Nov 07 '23 12:11 patricklx

@chancancode can you have a look at this? At least i would like the object/property info on the tag for inspector

patricklx avatar Feb 26 '24 16:02 patricklx

Is there a way to make it faster?

NullVoxPopuli avatar Jun 11 '24 17:06 NullVoxPopuli

Is there a way to make it faster?

Maybe, nodejs creates a new hidden class whenever a new property is added to an object... Lets see if thats the cause

patricklx avatar Jun 11 '24 22:06 patricklx