Patrick Brouwers

Results 100 comments of Patrick Brouwers

Please provide a PR with a suggested fix. Please note that as we support multiple PHP versions, we never intended it to be used as named parameters.

I think this is because we use `chunk()` instead of `chunkById` I'm not sure if we can just switch that.

I think the issue is that you using without chain, there's no way for us to know if its the last chunk or not.

As I said, without the chain it is not possible to be sure a specific job executes last. Depending on the amount of workers any job could be the first...

I forgot we had that option. That should indeed prevent the clean-up of the remote file until 10 minutes later. Perhaps not all queue worker support it? Are you using...

@mgratch sorry the question was intended at @mahdi29 haha. Make sense it work on those 2 yes.

You could try WithColumnLimit. Other than that there isn't really anything we can do in this package, as the toArray logic is from PhpSpreadsheet

As mentioned in #3560 I would be okay with a `SkipsCleanup`. Skipping the entire after import job, also removes the benefit of being able to use the event system.

Besides that batches indeed aren't supported by