patrickariel comments

Results 9 comments of


                                            patrickariel

Deprecate bundles in favor of Required Components

I've opened a PR for this, if you want to test it out: https://github.com/StarArawn/bevy_ecs_tilemap/pull/604

Tiles probably should not be "children" of tilemaps

@cpetzold > I'm also not sure if it's possible to replace TilemapStorage with a RelationshipTarget because of the TilePos grid storage, but it'd be neat if it worked. Yeah, I...

Return a proper error for `into_inner`

Thanks for the feedback, I changed it so that the error stores the original vec, allowing the user to recover it using `take_vec`. > Workaround for your use case: You...

Better typesafety for `useInfiniteQuery`

Anything I can do here to move this forward?

Return `StatusCode` instead of `u16` for inferred responses

Should I bump the version in this PR?

Return `StatusCode` instead of `u16` for inferred responses

I feel like that would unnecessarily bloat the new method names (e.g. `inferred_responses_typed`). Also, making a new method for an incremental improvement doesn't feel quite right to me. But if...

Return `StatusCode` instead of `u16` for inferred responses

Alright makes sense. So you're saying that a new temporary method should be introduced, which can then be merged into the older one on the next breaking major release, right?...

Deprecate `data_unchecked` and `data_opt` methods

Thanks for the link, I think that's a good reference for the `_unchecked` convention in general. > #### Dynamic enforcement > Validate the input as it is processed (or ahead...

Deprecate `data_unchecked` and `data_opt` methods

To clarify, the PR only marks these methods as deprecated, it does not remove them. I'll leave it to the discretion of the maintainer as to when it actually gets...