fluent-bit-docs icon indicating copy to clipboard operation
fluent-bit-docs copied to clipboard

Published 20 hours ago • verified publisher icon fluent

out_loki: make it clear setting labels removes the keys from record

Open ajantti opened this issue 11 months ago • 1 comments

Related to the pull request https://github.com/fluent/fluent-bit/pull/9766 The documentation doesn't make it clear, but the code seems to be trying to work this way.

Also minor typo fix.

ajantti avatar Dec 25 '24 06:12 ajantti

Thanks for the contribution but please resolve the DCO requirements - we cannot merge without it unfortunately.

patrick-stephens avatar Jan 06 '25 09:01 patrick-stephens

@ajantti I've nudged the code PR https://github.com/fluent/fluent-bit/pull/9766 for review to get that moved forward, once that is merged, this docs PR could merge if you could please fix the current conflicts?

eschabell avatar Oct 21 '25 20:10 eschabell

@esmerel another one to review and not merge please, just need the review!

eschabell avatar Oct 21 '25 20:10 eschabell

Sorry for taking a while. The conflict was in a minor typo fix, but I hope the thing I wrote about the labels is correct. It's just a clarification on how I think it's supposed to work, based on the pull request https://github.com/fluent/fluent-bit/pull/9766

Although, as mentioned in the comments of the pull request, I think it might've been already accidentally fixed in master by https://github.com/fluent/fluent-bit/pull/10563 (albeit with some inefficiencies)

ajantti avatar Nov 05 '25 03:11 ajantti