Patrick Naylor

Results 7 comments of Patrick Naylor

@Illviljan That is definitely something I could do. Are there any other methods I should be including in this?

Great I'll start working on that. Shouldn't take too long

Thanks @dcherian, I'll try to work that in. Is there a particular reason why there is no cumprod for GroupBy objects?

> ```python > def cumsum(..., dim): > return xr.apply_ufunc( > np.cumsum if skipna else np.nancumsum, > obj, > input_core_dims=[dim], > output_core_dims=[dim], > kwargs={"axis": -1}, > ) > # now transpose...

I've merged the cumulative and reduction files into generate_aggregations.py and _aggregations.py. This uses the original version of reductions with an additional statement on the dataset methods that adds the original...

@dcherian Do you think it would be better to finish this PR as the creation of _aggregations.py to give the cum methods better documentation? Then start a new one to...

Thanks @Illviljan, @dcherian, and @keewis so much for the help.