Patrick Kelly

Results 8 comments of Patrick Kelly

For what its worth I tried adding the props selected and disabled. ```h("option", { props: { value: "", selected: true, disabled: true } }, ["choose"]),``` In Firefox the red outline...

What about making it a plugin?

> Question: not using prop types does seem to make sense in a TypeScript end-project. But what about a React component that is published somehow and could be used in...

I would be interested in knowing if they plan to keep it. 2 years ago @gaearon mentioned that they don't have any plans to remove them. But he also said...

I think I'm looking at the correct function.. It looks like it tries to remove the key before it creates one.. ![image](https://github.com/user-attachments/assets/ffc6861a-ab06-4092-a396-546fb0e2d7fc) But it is not removing them with the...

How about something like this? ![image](https://github.com/user-attachments/assets/02fdeaba-ba66-4103-ac1a-c8c4e37acab6)

PR [#3788](https://github.com/graphql/graphiql/pull/3788)

> I don't think this does anything to fix the problem. The original issue was that the keyMap is added as an Object, but then removed via each individual key,...