Björn

Results 158 comments of Björn

@kylebarron thanks for suggesting, this would be a nice improvement. We have to make sure that all shields we would use from the links you provided are CC0 and document...

In general I think it would be a good idea to add the `` tag way to use https://github.com/orangemug/mapbox-gl-tokens to the example code in the _usage_ part of the README.md...

> Would we need to delete the usage? With https://github.com/orangemug/mapbox-gl-tokens I think it could just change it to be the same usage as outlined in the mapbox-gl-tokens README with a...

Hi @amenk, > Can we render such name tags? In general, yes. > Do they need to be included in OpenMapTiles first? Yep, they are currently not included: ![grafik](https://user-images.githubusercontent.com/20856381/114294116-6da46c80-9a9c-11eb-9465-4b2805b0be2e.png)

We could add these buildings names to the OSM Liberty style if they would be available in OpenMapTiles. Currently this is not the case. If you would like to have...

Hi @kylebarron thanks a lot for your PRs and comments, I need to take a closer look. > It's impossible to create a small diff because maputnik reformats the JSON...

@kylebarron I formatted the style you submitted with your PR with [`gl-style-format`](https://www.npmjs.com/package/@mapbox/mapbox-gl-style-spec#gl-style-format), then there's a small diff. Could you please do the same, so it's possible to review the changes....

Ahh, you're using https://github.com/maputnik/desktop. I was refering to the online version: https://maputnik.github.io/editor/ When you export a style with the online version, the style is formatted with `gl-style-format`. Opened an issue...

> Also, regarding the PR's styling changes, I think it's too confusing for a general basemap currently Yep. I think so, too. > I'd think that I should take labels...

Thanks for the PR @kylebarron, the shields are looking great! I also do also think that the icons could be a smaller. > I was modifying the source SVGs to...