patak

icon indicating a website link patak.dev

icon company @StackBlitz icon location Matias Capeletto • @vitejs Core Team • @vitest-dev @elk-zone Team • Open Source @stackblitz

Results 228 comments of patak

fix: read sec-fetch-dest to detect JS in transform

> Hmm, after thinking this through, running the `src` of module scripts through `markExplicitImport` sounds like the more straight-forward solution to this specific problem 🤔 WDYT? If I understand you...

fix: read sec-fetch-dest to detect JS in transform

> > If I understand you correctly, you want us to start marking every known JS source with ?import, both in and when doing an import in a module >...

fix: read sec-fetch-dest to detect JS in transform

@haikyuu you may want to use a utility like `injectQuery` https://github.com/vitejs/vite/blob/9f8d79b9897427882bb7da1bdb7862a15938c865/packages/vite/src/node/utils.ts#L307, you need to keep the other queries. Note: Maybe we could expose `injectQuery` as an util in the vite...

fix(plugin-legacy): force set `build.target`

It is interesting that this wasn't found before, thanks for digging into it Sapphi. I think this PR is a good first step. We can release it as a minor...

fix(plugin-legacy): force set `build.target`

Let's release this PR in a new minor for plugin-legacy tomorrow.

fix(build): fix resolution algorithm when `build.ssr` is true

One improvement we could do before merging is to move the new tests to an existing playground. Our e2e CI is taking quite a bit of time already so we...

fix(build): fix resolution algorithm when `build.ssr` is true

@mrm007 would you address @ydcjeff comments first? Thanks!

fix(build): fix resolution algorithm when `build.ssr` is true

@benjervis would you send a PR cherry-picking this one to the `v3.1` branch?

feat: include duplicate assets in the manifest

I think this is a good solution for including in 3.1. For Vite 4, we may want to revisit how the dedupe of assets works, see discussion in: - https://github.com/vitejs/vite/issues/8632...

feat: include duplicate assets in the manifest

We discussed this PR in today's team meeting and we think it is good to be merged. We are going to keep the deduplication of assets, but we think the...