Patrick Yeo

Results 76 comments of Patrick Yeo

1) The screen reader should be announcing the title when you focus the checkbox. It only announces "unchecked checkbox" when you tab to it. ![treeview-checkbox](https://github.com/user-attachments/assets/ef85aa0c-e5a1-4210-b5fb-6402fa8a07d9) The announcement should be "Entering...

I'm seeing issues in Treeview with checkboxes. It's selecting / unselecting everything. ![treeview-selection](https://github.com/user-attachments/assets/5469f34f-73cc-4625-b508-b36d25fd30b6)

@MarioLeandro the checkboxes shouldn't be selected / unselected when clicking to expand. It should only be selected when clicking the checkbox. It seems to be a previously existing bug with...

@MarioLeandro We can use `` directly without TS errors. Not sure if we needed this pattern when we were on an older version of TS or not, but we don't...

@MarioLeandro directly replacing seems to be working for me without issue, see my commit at https://github.com/liferay/clay/pull/6217.

@MarioLeandro we just need to reduce the number of commits, otherwise LGTM