Patrick Yeo

Results 52 comments of Patrick Yeo

@plhnk 🤔 It seems like what you're suggesting is combining https://liferay.design/lexicon/ with https://clayui.com/.

It would get polluted, but hopefully the pollution will live inside the `_clay_variables.scss` file where it's separated from the framework. We have variable pollution right now which is hard to...

The variables file will be more complex. Here is another more refined example of what it would look like: ###### variables/_buttons.scss ```scss $btn-selectors: ( '.btn': ( cursor: $link-cursor, font-size: 1rem,...

We have styles for HTML5 form validation from Bootstrap. It's deprecated and doesn't conform to Lexicon's design because we didn't use it. The styles are pretty similar though. We can...

@marcoscv-work I believe our icons are already namespaced. All those icons are prepended with `lexicon-icon-`. We can add documentation on it?

Working well for me, the only nitpick I have is with the `focusRing` attribute. Should the `focusRing` values be swapped? What I mean is `focusRing={false}` should trigger rendering the `c-inner`...

I don't think we need to add the `focus-ring` and `show` classes. We can leverage the browser's `:focus-visible` pseudo class, but we would need to move the focus `box-shadow` style...

This seems like an improvement for most cases. For the minority that don't want it, we can provide a way to revert back with a variable like `$enable-focus-visible` or through...

My initial thought here is to create an Atlas custom properties variable theme in Clay where we can adopt CSS Custom Properties. The problem is Clay 3.x is used in...