Filipe Azevedo
Filipe Azevedo
They want not that feature in LE - not enough user friendly ðŸ˜
> I gave the code a very quick review - great work :-) > > It needs tests though, both in the vfs layer and in the mount layer. The...
> Let me know if you want help writing the tests. Thanks, that would be greatly appreciated. How do I build unit tests and run them ? I saw there...
@ncw I just rebased atop master. I'm trying to add tests, but I have to be honest, i'm lost. How would I test mount (3 variants) and test Readlink /...
Thanks for the hints, will have a look. > One thing I noted is that this should probably be gated on a flag - I don't think you have that...
Hm, how would I trigger tests ? I tried `make quicktest` but it lead to plenty of failing tests, even with bare master ?
Not yet, while it works fine cache less, it cause troubles with the cache system due to the names translations. Also still writing the unit tests to ensure correctness
@ncw I would like your inputs. I have refactored the current work into a new branch @ https://github.com/pasnox/rclone/commits/master-vfs-symlinks The changes are much proper and enable a --link flags. I redesigned...
@ncw Neverming, I found VFS.Dir.stat which is where I think node lookup should be tweaked, similarly to the insensitive lookup. Refactoring is nearly finished, then I can write all those...
@ncw Open for review now with unit tests and --links command line switch.