Pascal Kuthe

Results 451 comments of Pascal Kuthe

Actually crossterm does look like its taking up a bit more space in that flamegraph although not by a huge amount. Probably doesn't matter much in practice. Couldn't we just...

> The one by this PR actually looks shorter though? There's some mentions about enabling this feature and dropping `mio` so it might not make sense to have it conditionally...

Thanks for the benchmarks! Interesting how different linux and mac are. Is it possible you switched the flamegraphs up in your earlier comment? It looks like this PR is a...

> I'm running into this crash on a Mac with crossterm 0.26.1 (so with @yyogo 's crossterm patch). How do I properly configure my build of helix to use tty?...

We do still want to do command expansion for shell commands but kakoune does that tok so matching whatever they do should work

That seems mostly correct and match vim but symlinks should still be opened if they point qt a file or directory. Not sure how is_file handles those

Why did you move clients out of registry? The registry is supposed to be exactly that a list/registry of all lsp "clients"

the nix config can generate a scheme config file. This likely won't cover the full customizability of a scriptable config but it wouldn't be much worse than what we have...

I don't intend to continue the long discussion that was there already on this here (that would sidetrack the issue). I will mark further comments regarding this as off topic....

> I'm curious, how easy is it to (de)serialise scheme compared to toml? Its not a dataformat it's a programming language so there is not deserialization. You execute code in...