Pascal Kuthe

Results 293 comments of Pascal Kuthe

I linked to the current development thread from ubunt in the original description. They usually take a few days to bump rustc and firefox but they have it as a...

> With the bump to 1.61, > > https://github.com/helix-editor/helix/blob/4c9f144dace484ca99cc84053493ed7b5f6946ac/helix-term/src/ui/picker.rs#L368-L370 > should now be removed together with the crate import I updated the PR accordinly

It seems the pipeline is failing because gitoxide has MSVR of 1.59 but helix currently targets 1.57. Gitoxide has been targeting newer versions for quite a while so downgrading doesn't...

Whether gitoxide or git2-rs is used doesn't make too much difference for this PR. I was able to convert my implementation to git2-rs fairly quickly I was able to remove...

I have discovered that the current diffing implementation I reused from #1623 has major shortcomings. I am working on improving this but it will take a while

In the previous PR diffing was implemented using the helix internal changeset after a suggestion by @archseer. While using this PR in practice I noticed that this approach does not...

> There are quite a few grammar mistakes in the comments. Should these be addressed in a follow-up PR so as to not clog up this one? I am still...

@Byran Sorry it took a while to respond to your points but solving your suggestions turned out more complicated then expected. > I also hope that in future iterations it...

I like the current default but also think customization would be nice. I was planning to implement customization in a follow-up PR to keep this one easier to review. Is...

> Using this for some time already, works pretty great so far. > > A few things I noticed though: > > * Staged changes are still displayed as changes,...