Parker Moore
Parker Moore
Hey @ashmaroli, this is in my queue to review but my high level thoughts are: 1. Lack of consistency with Jekyllrb.com is not desirable IMO. I prefer them to be...
We could write these to the documentation so that when contributors change the options, the documentation is automatically updated by an Action.
I like this! It'd be really cool if we could mark the options as required inline instead of needing to do that in the `validate` func.
I see these too, but I do not know what files cause this. Is there a way for me to do this? I get a HUGE list of these errors,...
Here's an idea of how to accomplish this with Luxon: https://github.com/moment/luxon/issues/274#issuecomment-729126515
Dang, Luxon.min.js is 68K and moment.min.js is only 58K. For simplicity's sake, I'll stay with moment until it's truly retired.
I might recommend separating the addition of the webrick and the modification of the docket files into two separate PRs. Otherwise LGTM.
Filed in the gem that caused this error: https://github.com/jekyll/github-metadata/issues/283
@visionmedia You still maintaining this project?