ejs icon indicating copy to clipboard operation
ejs copied to clipboard

Please create a new npm release

Open fiznool opened this issue 10 years ago • 12 comments

v1.0.1 to include the fix for #130

fiznool avatar Jul 02 '14 08:07 fiznool

@visionmedia You still maintaining this project?

parkr avatar Sep 16 '14 18:09 parkr

@parkr I'm ostensibly maintaining this, although I haven't had a chance to do much with it yet. I'll make sure I can publish to NPM and try to get a new release by the end of the week. Thanks for your patience.

mde avatar Sep 16 '14 18:09 mde

No problem, @mde! Just curious. Thanks for the time you can contribute to the project. :smile:

parkr avatar Sep 16 '14 18:09 parkr

ping

silverbucket avatar Dec 25 '14 10:12 silverbucket

Pong. :) It's the holidays! I'm looking at this PR: https://github.com/tj/ejs/pull/156 and trying to get tests passing before I try to push.

mde avatar Dec 25 '14 17:12 mde

@parkr and @silverbucket I am putting together a v2.0 here: https://github.com/mde/ejs It uses a preexisting implementation I bundled with Geddy, and I believe I've got feature parity (except for filters, which I'd like to deprecate). Could y'all give it a quick look and let me know what you think? If it's kosher, I'll push it out to NPM in the next day or so.

mde avatar Jan 02 '15 21:01 mde

@mde do you have a changelog?

parkr avatar Jan 02 '15 21:01 parkr

@parkr Good call: https://github.com/mde/ejs/blob/master/CHANGELOG.md

There are backward-compat shims for the change to separate data/options, and for the include function. No changes to existing code should be necessary for those. The only breaking change is the removal of filters.

mde avatar Jan 03 '15 04:01 mde

:+1:

parkr avatar Jan 03 '15 05:01 parkr

What is the rationale behind removing filters in this release? I was using them extensively and was quite happy with them?

little-big-h avatar Jan 04 '15 18:01 little-big-h

Filters are not an EJS-specific feature (none of the other implementations have it), and can be implemented just as easily using external helper functions. It's just JavaScript, and you can run whatever functions you want inside your templates.

I want to keep the core of EJS small and limited to plain JavaScript. If you really depend on filters, you can continue to use them with v1 for now.

Having said that though, I'd be interested in providing an easy way for you to plug filters in (maybe with custom tags?), and I'd love to work with somebody to add that functionality.

mde avatar Jan 04 '15 19:01 mde

+1 for removal of filters, kinda weird, not sure why I added them

tj avatar Jan 04 '15 22:01 tj