Rajat comments

Results 329 comments of


                                            Rajat

trafficstars

[$1000] Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field.

@pecanoro What do you think will be best to do here? There are two ways to solve this. 1. Trim the content before we save the draft in the Form...

[$1000] Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field.

Got it. Now the question is when should we trim these values? Trimming the values while the user is typing is bad which we are trying to get away from...

[$1000] Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field.

I am still figuring this out. > Let's trim the values after either moving forward or moving back and saving them as drafts, That will not always solve the problem....

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

Yes, can you share the screenshots to clarify.

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

I will do that as soon. Currently working on an internal PR which is urgent.

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

Gonna check this today before EOD.

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

I am away for 3:30 hrs. Then I will start the review process here.

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

I am curious about the end result after https://github.com/Expensify/App/pull/17496 is merged. let's just wait for some time and I am sure that it will be merged today.

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

@Ollyws I would say that you put back the MiniReportActionContextMenu change as it does not affect anything but solves a bug. It is good if #18228 make is future-proof. let...

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

### Screenshots #### :black_square_button: iOS / native https://user-images.githubusercontent.com/24370807/235654822-8de4a9c4-6333-4cce-b5ba-9dd3c3a804fc.mov #### :black_square_button: iOS / Safari https://user-images.githubusercontent.com/24370807/235654636-92edc028-a6e8-4457-b784-ab2bb6c60bf0.mov #### :black_square_button: MacOS / Desktop https://user-images.githubusercontent.com/24370807/235657611-def0af4a-add6-4a3a-ac68-f28dbbb7d55d.mov #### :black_square_button: MacOS / Chrome https://user-images.githubusercontent.com/24370807/235654845-e8f73efe-6693-4079-9f51-3d702f60f08e.mov #### :black_square_button: Android /...