Rajat
Rajat
@kerupuksambel tests are failing. Can you please test your proposal and fix it so that it does not break old tests? Also, you will have to add more unit tests...
Ok so I tested it. It is looking good. the _javascript: scheme part_ . let's say the parser is parsing ``` javascript:console.com ``` Your solution will give us ``` https://javascript:console.com...
> If the url parameter of currency is different than current policy currency stored in onyx, should we change the selected currency based on the url parameter? Only on Currency...
Apologies for the delay here. I had build issues last week so couldn't focus on it. Unfortunately, I will be AFK till the weekend. But I am sure I can...
There is another variant of such a pattern in the APP used around `CountrySelectionPage`. Things to check would be comparing and seeing what is different between both. And can we...
I am currently OOO. I plan to continue this in 2 days. There are no urgent PRs/issues on my side so I would be able to fully focus here.
Thanks for waiting here. It's been long but I was somewhat waiting on request flow migration done by Tgolen which would update `IOUCurrencySelection`. But it seems that we are completely...
We might want to hold on https://github.com/Expensify/App/issues/34607 as it could help us with the migration of this PR to the new component without conflicts.