Ufuk Kayserilioglu comments

Results 60 comments of


                                            Ufuk Kayserilioglu

compilers/active_record_associations.rb always generates T.nilable(singular_model_name) on belongs_to and has_one

@YukiJikumaru The fact of the matter is, those conditions on associations, like `optional` or `required`, only change the behaviour of persisted records. However, ActiveRecord models can also be non-persisted, and...

Anayasa değişiklikleri

:+1:

Prevent invalid signature unwrapping for overridden methods

> I'm surprised that we have a compiler test specifically testing this scenario and mentioning that it is allowed. Any context on why? As per my comments above, I think...

[LSP]Sorbet's language server requires a single input directory

@crokobit @arpitsr @styrmis Your reports are not related to this issue at all. On the surface, the errors look similar to the original reported issue, but your problem is completely...

[LSP]Sorbet's language server requires a single input directory

@styrmis I also noticed that your Sorbet LSP invocation has a `--no-config` flag which is probably the real reason for your original problem. You can't expect Sorbet to work properly...

Methods defined on anonymous classes cause typing errors

Oh wow, great find @bss, thanks for looking into this. We have some instances of bare anonymous class definitions in our codebase, that is mostly to do with some mock...

Methods defined on anonymous classes cause typing errors

> ... there's no easy way to coordinate to ensure that anonymous class names are globally unqiue Do we need them to be globally unique **and** stable? If not, we...

Prevent invalid signature unwrapping for overridden methods

@froydnj I just got pinged that we experienced a small incident due to this behaviour, so I'd like to see how we can move this forward. The incident was caused...

Signatures for `attr_accessor` won't add runtime checks to the writer method

This is still an open issue since the fix has to be reverted in https://github.com/sorbet/sorbet/pull/6505

A way to install Placeholders.js via composer

Hey @eSlider, I am not a maintainer of this project, so can't do that I'm afraid. I think @jamesallardice is the only person that can do this.