timezone

timezone copied to clipboard

fredbaa

Wrong error raised for Geonames Lookup

1

According to README: ``` Timezone.lookup(10, 10) => Timezone::Error::Geonames: api limit reached Timezone.lookup(10, 100000) => Timezone::Error::InvalidZone Timezone.lookup(10, 100000, Timezone::NilZone.new) => # Timezone.lookup(10, 100000){ |name| "#{name} is invalid" } => " is...

Chambeur

Use existing `google_request_denied.txt` mock

8

Don't suppress any errors, please.

AlexWayfer

Please, don't test private methods via `send`.

AlexWayfer

Is it possible to add additional params for geonames?

2

http://www.geonames.org/export/web-services.html#timezone Parameters : lat,lng, radius (buffer in km for closest timezone in coastal areas),lang (for countryName), date (date for sunrise/sunset); Is it possible to add these params when calling .lookup?

dobryakov

Hi there! After updating my Rails 7 app from Rake v13.1.0 to [v13.2.1](https://github.com/ruby/rake/releases), I now encounter the following exception when attempting to boot Rails: ``` /Users//.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/timezone-1.3.25/lib/timezone/lookup.rb:61:in `initialize': uninitialized constant Timezone::Lookup::OptionSetter::OpenStruct...

moneill

Add Ruby 3.2 to CI and update RuboCop

3

This PR adds Ruby 3.2 to the CI matrix and updates RuboCop to a version that can be run with that Ruby version. Getting everything green required: 1. Updating the...

petergoldstein

Invalid Zone error on real coordinates lookup

1

`Timezone::Error::InvalidZone (Timezone::Error::InvalidZone)` raised with `Timezone.lookup(1.9856557, -157.3504973)` which are the coordinates for [Cassidy International Airport](https://www.google.com/maps/place/Cassidy+International+Airport/@1.9856557,-157.3504973,15z/data=!4m5!3m4!1s0x0:0x99ab09a901b62e75!8m2!3d1.9856557!4d-157.3504973) Expected result: `Pacific/Kiritimati` Using gem version 1.3.21

eric-norcross

Makes it easier to navigate to the changelog from rubygems.org or CLI tools which use this field :)

jaredmoody

Related: https://github.com/panthomakos/timezone/issues/108 Ruby 3.4 warns when using OpenStruct. Ruby 3.5 will remove it, and you'll need to include the `ostruct` gem. It looks like the usages here could be converted...

ksweetie