Is it possible to add additional params for geonames?

Open dobryakov opened this issue 8 years ago • 2 comments

http://www.geonames.org/export/web-services.html#timezone Parameters : lat,lng, radius (buffer in km for closest timezone in coastal areas),lang (for countryName), date (date for sunrise/sunset);

Is it possible to add these params when calling .lookup?

Sep 13 '17 14:09 dobryakov

Adding radius seems possible. Can you outline an example use-case for how you envision that value would be configured?

I don't see how the other options would be useful because the lookup call is only interested in the timezone name. Can you provide some more details about how these other parameters would be used; or how they would alter the lookup result?

Sep 19 '17 04:09 panthomakos

FYI: this PR was opened, but never completed, and it adds the radius option: https://github.com/panthomakos/timezone/pull/55

Sep 19 '17 04:09 panthomakos