Walter Pagani
Walter Pagani
Correct, it should be corrected.
Thanks to all who participated.
I haven't really tried these changes. But I see 2 people say it works. Therefore, I am going to give it my approval so that it can be merged.
This is a personal opinion and you may not agree with me, but it would be interesting if we could, when creating a pull request, respond at least and give...
At first glance, reviewing the code, it is understood that it was a possibly typing error and it is good that it be fixed. I thought you tried it. Perhaps,...
> Sure, I don't see any reason why this should not be merged. Done
> Thanks for the PR! > > I feel like this should maybe be somehow combined with the "blizzlike_pvp_los" setting that is right above the new setting? > > Or...
It is likely that it can be combined. However, the name above would have to be changed. And it should possibly be enabled by default. Because I don't remember if...
I don't know if it would be possible to combine it through an OR perhaps. I'm throwing out ideas, without really trying them. ```cpp if (!sWorld->getBoolConfig(CONFIG_VMAP_BLIZZLIKE_PVP_LOS) || sWorld->getBoolConfig(CONFIG_VMAP_PVP_LOS_IN_OPEN_WORLD)) { if...
> I thought about something like this: > > ```c++ > if (!sWorld->getBoolConfig(CONFIG_VMAP_BLIZZLIKE_PVP_LOS)) > { > if (IsBattlegroundOrArena()) > { > ignoreFlags = VMAP::ModelIgnoreFlags::Nothing; > } > } > >...